Log handler example in documentation fails to show correct extended result code name

[2-5]

The suggested logging handler shown here: https://rogerbinns.github.io/apsw/tips.html#diagnostics fails to show the extended result code name, because it incorrectly clears the lower bits (& ~ 255).

Test case with suggested fix (handler_fixed):

import apsw

def handler(errcode, message):
    errstr=apsw.mapping_result_codes[errcode & 255]
    extended=errcode & ~ 255
    print ("SQLITE_LOG: %s (%d) %s %s" % (message, errcode, errstr, apsw.mapping_extended_result_codes.get(extended, "")))

def handler_fixed(errcode, message):
    errstr=apsw.mapping_result_codes.get(errcode & 255, "<NO_RESULT_CODE>")
    errstr=apsw.mapping_extended_result_codes.get(errcode, errstr)
    print ("SQLITE_LOG: %s (%d) %s" % (message, errcode, errstr))

def test_log():
    apsw.log(apsw.SQLITE_IOERR_ACCESS, "bla")
    apsw.log(apsw.SQLITE_CONSTRAINT_DATATYPE, "bla")

print("=== ORIGINAL HANDLER ===")
apsw.config(apsw.SQLITE_CONFIG_LOG, handler)
test_log()
# PRINTS:
# SQLITE_LOG: bla (3338) SQLITE_IOERR
# SQLITE_LOG: bla (3091) SQLITE_CONSTRAINT

print()

print("=== FIXED HANDLER ===")
apsw.config(apsw.SQLITE_CONFIG_LOG, handler_fixed)
test_log()
# PRINTS:
# SQLITE_LOG: bla (3338) SQLITE_IOERR_ACCESS
# SQLITE_LOG: bla (3091) SQLITE_CONSTRAINT_DATATYPE

[rogerbinns]

Thanks for spotting that. It was written with the (incorrect) model that the bottom 8 bits error code was independent of the top 24 bits, and that they would be mixed. They aren't and the rest of the code and doc needs verification that this isn't happening anywhere else.