Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Documentation Website #22

Merged
merged 18 commits into from Nov 8, 2022

Conversation

thetejasmagade
Copy link
Contributor

hey, @rogeriotaques sorry for the late..
Website is now ready. Tell me changes if you want.

See preview here
https://dynamic-biscochitos-d8d357.netlify.app/

@rogeriotaques
Copy link
Owner

It looks great, @thetejasmagade! Good job.

I have just a very few suggestions:

Screen Shot 2022-09-19 at 18 36 03

Considering the commands are already mentioned in the Get started section, they look duplicated in these blue boxes. So, I would replace them with a Try it out and remove the grey-ish "Try it out" button from the button row. As in the image above.

Also, I think I would give a bit more padding to that Documentation button.

But, one very important thing I am missing from that page is your name as the contributor. 😉 Please, don't forget to include your name in there.

@rogeriotaques rogeriotaques added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 19, 2022
@thetejasmagade
Copy link
Contributor Author

Hey, @rogeriotaques my friend can you please do that changes for me that you have mentioned. Please 🙏❤️

@rogeriotaques
Copy link
Owner

Sure, but it may take a while since I'm a bit short on time these days. 😓

@thetejasmagade
Copy link
Contributor Author

I also have University exams and all that stuff 😂😂. But, don't worry I will try to do it.

@rogeriotaques
Copy link
Owner

Don't worry, mate!
University duties first, for sure. 💪🎓

@thetejasmagade
Copy link
Contributor Author

Yes 💯

@thetejasmagade
Copy link
Contributor Author

thetejasmagade commented Nov 5, 2022

Hey, @rogeriotaques did changes that you have mentioned

@rogeriotaques rogeriotaques merged commit db3c4fb into rogeriotaques:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants