feat(apply-context): Support MongoDB ObjectId as context variables #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hybrid-Force
force-pushed
the
object-id-context-variable
branch
from
b4ce929
to
e92c138
Compare
roggervalf
reviewed
Aug 18, 2022
src/utils/applyContext.ts
Outdated
| @@ -36,7 +39,10 @@ export function applyContext<T extends object>( | |||
| str.replace(reDelimiters, (_, path: string) => { | |||
| const value = getValueFromPath(context, path); | |||
| if (Array.isArray(value)) return `{${value}}`; | |||
| if (value instanceof Object) return 'undefined'; | |||
| if (value instanceof Object) { | |||
| const json = value.toJSON?.(); | |||
There was a problem hiding this comment.
I'm seeing that the error is coming from this line because of the .
There was a problem hiding this comment.
Got it. Optional chaining is not supported in Node 13 and below. I will fix it.
roggervalf
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Thank you @Hybrid-Force, just for curiosity, how are you using this package?
github-actions bot
pushed a commit
that referenced
this pull request
Aug 18, 2022
# [4.17.0](v4.16.0...v4.17.0) (2022-08-18) ### Features * **apply-context:** support objects with toJSON method as context variables ([#88](#88)) ([ecb3dbc](ecb3dbc))
|
🎉 This PR is included in version 4.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks for this great lib! I am using it for API access control of a multi-tenant app that I am working on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MongoDB ObjectId support as context variables, and hopefully other types of objects with
toJSONmethods returning strings.