Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/testscript: document -work flag in help and README #123

Merged
merged 1 commit into from Jan 21, 2021
Merged

cmd/testscript: document -work flag in help and README #123

merged 1 commit into from Jan 21, 2021

Conversation

myitcv
Copy link
Collaborator

@myitcv myitcv commented Jan 19, 2021

No description provided.

@myitcv myitcv requested a review from rogpeppe January 19, 2021 11:56
mvdan
mvdan approved these changes Jan 20, 2021
View reviewed changes
Copy link
Collaborator

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps clarify that the scripts still run, e.g:

The -work flag prints the temporary work directory path before running each script, and...

@myitcv
Copy link
Collaborator Author

myitcv commented Jan 21, 2021

Good suggestion, thanks. Changes made - will merge on green.

@myitcv myitcv force-pushed the cmd_testscript_document_work branch from 97d849f to 32f2c96 Compare January 21, 2021 09:05
@myitcv myitcv merged commit 6a414f0 into master Jan 21, 2021
@myitcv myitcv deleted the cmd_testscript_document_work branch January 21, 2021 09:11
This was referenced Mar 14, 2021
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdan mvdan mvdan approved these changes

@rogpeppe rogpeppe Awaiting requested review from rogpeppe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@myitcv @mvdan