testscript: provide WorkdirRoot as a new Params field #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myitcv
force-pushed
the
testscript_params_workdirroot
branch
from
998453b
to
de85f52
Compare
Via testscript.Params.TestWork, it is possible for the caller to prevent the work directories for scripts from being removed once complete. However the work directories for testscripts are created under a temporary directory and that working directory is not returned to the caller of testscript.Run. This makes it impossible for the caller to programmatically know where the resulting scripts are. We therefore provide testscript.Params.WorkdirRoot. WorkdirRoot specifies the directory within which scripts' work directories will be created. Setting WorkdirRoot implies TestWork=true. If empty, the work directories will be created inside $GOTMPDIR/go-test-script*, where $GOTMPDIR defaults to os.TempDir(). Also fix a bug whereby the value of $WORK was not printed as part of the verbose mode env when Params.TestWork was specified. i.e. it was impossible to see what the working directory was because all instances of the working directory value are replaced with the literal $WORK.
myitcv
force-pushed
the
testscript_params_workdirroot
branch
from
de85f52
to
7a45071
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.