Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testscript: fix race in setupfilenames test #88

Merged
merged 1 commit into from Jan 13, 2020

Conversation

myitcv
Copy link
Collaborator

@myitcv myitcv commented Jan 13, 2020

Also add go test -race ./... to CI

@myitcv myitcv requested a review from rogpeppe January 13, 2020 16:13
Copy link
Owner

@rogpeppe rogpeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one trivial thought, thanks!

.travis.yml Outdated Show resolved Hide resolved
Also switch to using -race in go test ./... in CI config
@myitcv myitcv force-pushed the testscript_fix_setupfiles_race branch from bc560b6 to 9ba619c Compare January 13, 2020 16:31
@myitcv myitcv merged commit ae313c1 into master Jan 13, 2020
@myitcv myitcv deleted the testscript_fix_setupfiles_race branch January 13, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants