Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testscript: support stdout/stderr in more builtins #94

Merged
merged 1 commit into from May 5, 2020

Conversation

mvdan
Copy link
Collaborator

@mvdan mvdan commented Apr 13, 2020

Support these special files in the stdin, unquote, and match (grep)
commands. This is particularly useful to "pipe" output like "stdin
stdout", or to use commands that produce txtar output.

The grep one isn't super useful, as one can already do "stdout xxx"
instead of "grep xxx stdout", but this way it's more consistent and we
save some repeated lines. Because the feature is itself a bit redundant,
don't document it, to prevent confusing the user.

@mvdan mvdan requested review from rogpeppe and myitcv April 13, 2020 12:48
This is particularly useful to "pipe" output like "stdin stdout". A
simple test is added.
Copy link
Collaborator

@myitcv myitcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but perhaps @rogpeppe will have some thoughts

@mvdan
Copy link
Collaborator Author

mvdan commented Apr 13, 2020

Also rog, ignore the PR title/body. The commit message is up to date.

Copy link
Owner

@rogpeppe rogpeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks (and sorry for the delay!)

@rogpeppe rogpeppe merged commit b01f880 into rogpeppe:master May 5, 2020
@mvdan mvdan deleted the cmds-stdout-stderr branch August 30, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants