Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor/ dir #52

Open
glycerine opened this issue Jan 21, 2017 · 3 comments
Open

vendor/ dir #52

glycerine opened this issue Jan 21, 2017 · 3 comments

Comments

@glycerine
Copy link

I love godef, but it doesn't seem to notice when a vendor/ directory is being used.

@aloucks
Copy link

aloucks commented Feb 9, 2017

I ran into the same thing when using glide.

I found this PR (which was closed without merging). I followed these directions on the pull request and got vendor directories working: #25 (comment)

@glycerine
Copy link
Author

glycerine commented Feb 9, 2017

@aloucks helpful thankyou. I wonder why folks seem to think that #33 fixed the issue, when apparently it does not? Maybe it was re-broken.

@pdf
Copy link

pdf commented Mar 14, 2017

~I tested this by reverting to d712540 and it still didn't work, so this hasn't been broken by subsequent commits to this repository. Perhaps this has been broken by changes in more recent Go versions? I only tested against 1.8, as I don't currently have a simple way to test against previous versions.~~

Thoughts @rogpeppe?

Scratch that, it appears the package I happened to test against specifies a vanity import path, and glide does not verify this, so it happily pulled in the github repo instead, hence the import could not be found. Apologies for the noise, this functionality appears to be working fine here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants