-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrupted SVG makes Chrome install impossible #6
Comments
I'm experiencing the very same problem on Chrome and I was already looking into it. Besides, if you can wait a couple hours I'll come back with a solution, if not I suggest releasing a 1.3.1 hotfix in which you revert b3613eb |
If you prefer, I can submit you a raster of |
Don't worry, take your time, I'm reverting to the previous version on chrome and leaving it on firefox cause it's still working ^^
It's simply when I'm uploading a plugin on Ff it analyze the code and dislay warnings and errors (as a normal compilator), that's all (nothing more sorry :x )
I know nothing about images on plugins (and not much about plugins neither...) so up to you ^^ You're the designer of the plugin and I'll let you do it as you prefer 😄 |
Even with just the revert commit it doesn't fix the issue for chrome... So I'll upload back to the v1.1 ^^ Also, I took an eye on the svg code and there's a lot of inkscape code... Couldn't you create a minified export or something without InkS. tags? 🤔 |
No problem, I was able to replicate the message using https://github.com/mozilla/web-ext and https://github.com/mozilla/addons-linter (the problem arise here https://github.com/mozilla/addons-linter/blob/a5b46c52d125c09324a1cbc36d81f5438c622777/src/parsers/manifestjson.js#L511) The apparent corruption is indeed caused by the odd xhtml notation used by the last version of inkscape (never been a problem before). It is fixable. Unluckily, due to this outstanding bug (https://bugs.chromium.org/p/chromium/issues/detail?id=29683) SVG icons are not an option at all for Chrome. It is my fault, I should have checked before. All my works on web extensions are always been on the Firefox platform, so today I learned something. |
If you still like my design, I will replace all svg with png files, exported on the right resolution. Still, I'm sorry for wasting your time 😅 |
It's okay, don't worry ^^ The best point is that you learned something ^^
Of course I love Squircled icons 😍
You don't I learned some things with all your links ! It was a pleasure to received your help ^^ |
Describe the bug
@Jackymancs4 The SVG is corrupted and Firefox give me some warnings about it and the plugin is impossible to install on chrome because of the SVG file...
I don't know how it works so can you help me with it?
The screenshot below is the firefox message (it's not much but it's all what I have) ^^"
Screenshots
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: