Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISCUSSION] Page Action v Browser Action #7

Closed
RoiArthurB opened this issue Sep 25, 2019 · 1 comment
Closed

[DISCUSSION] Page Action v Browser Action #7

RoiArthurB opened this issue Sep 25, 2019 · 1 comment
Assignees
Labels
enhancement 馃搱 New feature or request question 馃 Further information is requested

Comments

@RoiArthurB
Copy link
Owner

@Jackymancs4 I'm wondering about the choice of Page Action v Browser Action... 馃 馃

I mean, it looks absurd to have the plugin as a page action if it apply on every page.. It turns to be a Browser action finally, or in my sense it does 馃

I wanted to have your point of view on that, what do you think?

@RoiArthurB RoiArthurB added enhancement 馃搱 New feature or request question 馃 Further information is requested labels Sep 25, 2019
@RoiArthurB RoiArthurB self-assigned this Sep 25, 2019
@Jackymancs4
Copy link
Collaborator

Jackymancs4 commented Sep 25, 2019

Quoting from: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Page_actions

Use a page action when the action is related to the current page, and a browser action when the action is related to the browser as a whole or too many pages.

The way I see it is that it doesn't matter on how many pages it does apply, but the fact that the action modify every time only the specific page you are visiting.

if it apply on every page

It doesn't have to be this way. You could as an example filter out https://whereisscihub.now.sh/ since it does not make sense to allow the extension on that page (we know for sure it's not a research paper).

@Jackymancs4 Jackymancs4 mentioned this issue Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 馃搱 New feature or request question 馃 Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants