Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Extract formatters and make them configurable #88

Closed
pxlpnk opened this issue Sep 22, 2014 · 2 comments
Closed

Proposal: Extract formatters and make them configurable #88

pxlpnk opened this issue Sep 22, 2014 · 2 comments

Comments

@pxlpnk
Copy link
Collaborator

pxlpnk commented Sep 22, 2014

Before more formatters might be added I would propose that we extract the existing ones into single gems or a pack of formatters.
This helps in keeping the dependencies for lograge small, and the formatters could have what they need as dependencies.
Also people would be able to create their own specialised formatters.

@benlovell
Copy link
Collaborator

I'm not certain we're feeling the pain of those extra dependencies yet. The formatters themselves are very small and are not the subject of change generally. It's something to be mindful of though. I think when you trade off the extra complexity for configuration and maintaining backwards compatibility it outweighs the benefits at this stage.

Like anything though, I'm happy to hear others opinions. I'm not 100% committed either way.

@pxlpnk
Copy link
Collaborator Author

pxlpnk commented Sep 23, 2014

True the pain is not yet there(and might never be there).
Maintaing backwards compatibility is definitely harder then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants