Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated rbxl files have duplicate services when loaded #11

Closed
LPGhatguy opened this issue Feb 21, 2019 · 3 comments · Fixed by #81
Closed

Generated rbxl files have duplicate services when loaded #11

LPGhatguy opened this issue Feb 21, 2019 · 3 comments · Fixed by #81
Labels
module: rbx_binary type: bug Something isn't working

Comments

@LPGhatguy
Copy link
Member

This manifests itself mostly in Rojo -- services aren't tagged with the right piece of metadata in the binary format I don't think, which causes this fun:

image 11

@LPGhatguy LPGhatguy added the type: bug Something isn't working label Feb 21, 2019
@Kampfkarren
Copy link
Member

Kampfkarren commented Mar 21, 2019

Search the class name in rbx-reflection and check the tags?

@LPGhatguy
Copy link
Member Author

rbx_reflection is pretty new relative to rbx_binary, but yeah, I think that's the best plan!

@LPGhatguy
Copy link
Member Author

LPGhatguy commented Mar 22, 2019

Looking into the details of the format from the public sources available, I actually don't see where this metadata would even go. O_o

The additional data byte (defined by this document) isn't set for instances like Lighting in the example, but I was certain that would be the cause of this bug!

EDIT: After testing this, enabling the extra data segment does fix this bug. Neat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: rbx_binary type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants