Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbx_xml is slow! #74

Open
LPGhatguy opened this issue Sep 18, 2019 · 0 comments
Open

rbx_xml is slow! #74

LPGhatguy opened this issue Sep 18, 2019 · 0 comments

Comments

@LPGhatguy
Copy link
Member

Using an rbxlx version of the open source version of Miner's Haven as a benchmark.

$ cat decode.lua
remodel.readPlaceFile("minershaven.rbxlx")

$ time remodel decode.lua
real    0m24.496s
user    0m0.000s
sys     0m0.000s

$ du -sh minershaven.rbxl minershaven.rbxlx
7.6M    minershaven.rbxl
143M    minershaven.rbxlx

We might be able to recover some time switching to quick-xml, according to some profiling done by @Kampfkarren. Further investment in the binary format is the end-all solution to this, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant