Skip to content
This repository has been archived by the owner on Jul 22, 2023. It is now read-only.

remodel.writePlaceFile and remodel.writeModelFile do not write Part0 and Part1 properties #64

Closed
fredgig opened this issue Nov 2, 2021 · 3 comments · Fixed by #74
Closed
Labels
bug Something isn't working

Comments

@fredgig
Copy link

fredgig commented Nov 2, 2021

When reading a .rbxmx or .rbxlx (xml) file and writing it as a .rbxm or .rbxl (binary) file, any WeldConstraint inside the .rbxmx or .rbxlx file will lose their Part0 and Part1 property values.

This is not an issue with other instance types containing Part0 and Part1 properties like NoCollisionConstraint, but I have not tested many others.

I noticed that exporting xml files from Roblox Studio will use Part0Internal and Part1Internal as property names for WeldConstraint's, so it might be related to this issue.

Let me know if you need any more detail.

@fredgig fredgig changed the title remodel.readPlaceFile does not write Part0 and Part1 properties remodel.writePlaceFile and remodel.writeModelFile do not write Part0 and Part1 properties Nov 2, 2021
@fredgig
Copy link
Author

fredgig commented Dec 18, 2021

This issue now makes Remodel partly obsolete for us. It is no longer possible for us to publish our games with remodel.writeExistingPlaceAsset because WeldConstraint's are messed up in the process.

@NobleDraconian
Copy link

NobleDraconian commented Feb 19, 2022

This issue is still happening. I've attached a repro project file below.

Rojo7_RefBug_Repro.zip

Steps to reproduce
From the root of the repro project, run these commands:

  1. Run rojo build default.project.json -o Temp\CurrentBuild.rbxl

  2. Open the generated place file. Observe that Workspace.WeldedModel.A.WeldConstraint has its ref values (part0 and part1) intact.
    image

  3. Close the place file, and run remodel run AddGameVersion.lua.

  4. Open the place file. Observe that Workspace.WeldedModel.A.WeldConstraint has had its ref values wiped.
    image

@badcc
Copy link

badcc commented Mar 12, 2022

This is potentially same issue as rojo-rbx/rojo#458, I just encountered on =0.9.1

@LPGhatguy LPGhatguy added the bug Something isn't working label May 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants