Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bogus method overriding warning, when file included in component that is extended #113

Closed
georgejecook opened this issue Jun 16, 2020 · 1 comment · Fixed by #133
Closed

Comments

@georgejecook
Copy link
Contributor

This is easy to see in the open source MList project.

Compilation reports a ton of these warnings:

../../../../../tmp/buildTmp/source/rLog/rLogMixin.bs:84:10 - hint BS1010: Function 'logWarn' included in 'components/maestro/view/core/BaseScreen.xml' overrides function in 'source/rLog/rLogMixin.bs' included in 'components/maestro/view/core/BaseView.xml'.

 84  function logWarn(message, value = "#RLN#", value2 = "#RLN#", value3 = "#RLN#", value4 = "#RLN#", value5 = "#RLN#", value6 = "#RLN#", value7 = "#RLN#", value8 = "#RLN#", value9 = "#RLN#") as void
 84           ~~~~~~~                            

BaseScreen extends BaseView, which imports rLogMixin. the function is not redefined; BaseScreen does not import rLogMixin; but imports FocusMixin which does.

In any case, the compiler is wrong here, and even if one of BaseScreen's imports, imports rLogMixin, it should know it's already imported in BaseView, and not throw these warnings.

@elsassph
Copy link
Contributor

elsassph commented Jul 6, 2020

Any solution to that? I've added a diagnosticFilter for now:

    diagnosticFilters: [{
        'src': '**/*',
        'codes': [1010] // ignore override error
    }]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants