Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callfunc operator completions shows duplicate entries #662

Closed
TwitchBronBron opened this issue Aug 15, 2022 · 1 comment · Fixed by #664
Closed

Callfunc operator completions shows duplicate entries #662

TwitchBronBron opened this issue Aug 15, 2022 · 1 comment · Fixed by #664

Comments

@TwitchBronBron
Copy link
Member

TwitchBronBron commented Aug 15, 2022

Brighterscript shows some "slightly helpful" completions after the callfunc operator. However, those values aren't deduped. We should only show distinct method names.

image

This can be fixed by tweaking the code here to build the callfunc completions into its own array, deduping them, and then adding them to the final event.completions array.

Add another unit test like this one that has multiple functions with the same name across multiple components, and make sure only a single completion for each name is returned.

@TwitchBronBron
Copy link
Member Author

Looks like this is caused by having a child component that overrides a parent component's function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant