Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem in file reported in problems panel once for event location the script is included #46

Open
chrisdp opened this issue Oct 25, 2021 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@chrisdp
Copy link

chrisdp commented Oct 25, 2021

As shown in the image below bslint problems are being displayed for the same line one for every time the script is included in a component:

image

Ideally we would now show the same error the a given line more than once.

@TwitchBronBron
Copy link
Member

@elsassph how would you feel about combining all of these diagnostics into a single diagnostic? Something to the effect of:

"Using unitialized variable 'internalFocusedNodeChanged' when this file is included in 25 scopes ['components/comp1.xml', 'components/comp2.xml', ...]"

@elsassph
Copy link
Collaborator

Yeah I've been following brighterscript way of reporting the error. Could be combined for sure.

@TwitchBronBron TwitchBronBron added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 29, 2023
@TwitchBronBron
Copy link
Member

We've started migrating some of the brighterscript issues towards this pattern as well. See this function for an example:

https://github.com/rokucommunity/brighterscript/blob/master/src/bscPlugin/validation/ScopeValidator.ts#L341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants