Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option not to parse response as JSON #12

Closed
matus-tomlein opened this issue Nov 8, 2021 · 2 comments · Fixed by #28
Closed

Add option not to parse response as JSON #12

matus-tomlein opened this issue Nov 8, 2021 · 2 comments · Fixed by #28

Comments

@matus-tomlein
Copy link

It would be great if parsing responses as JSON could be made optional. I am accessing an API that accepts JSON in request body but responds only with the string "ok". This results in errors such as ERROR: ParseJSON: Unknown identifier 'ok'.

Could there be an option for it? Alternatively, the parsing could be dependent on the response content-type.

@TwitchBronBron
Copy link
Member

@matus-tomlein We'd be happy to accept a pull request for this.

@iBicha
Copy link
Contributor

iBicha commented Nov 7, 2022

@TwitchBronBron since the package is at 0.2.0, wouldn't it be better to introduce a breaking change, and make json into a method json()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants