Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable device discovery scanning when on a large network #500

Open
unwiredben opened this issue Sep 9, 2023 · 2 comments
Open

Disable device discovery scanning when on a large network #500

unwiredben opened this issue Sep 9, 2023 · 2 comments

Comments

@unwiredben
Copy link
Contributor

The current default for device discovery is fine when a developer is on a small network, but it can cause issues with network traffic on a larger network. I suggest that the default be based on the current network's netmask -- something with a /24 netmask (like a home network on 192.168.1.xxx) would be OK to default to scanning, while a /16 or /8 network would be out.

This would be especially useful for developers adopting this plugin at Roku, since one VSCode instance can end up discovering hundreds of devices.

@TwitchBronBron
Copy link
Member

I believe we already have a setting for this (assuming it isn't buggy...haven't tested it in a while).

brightscript.deviceDiscovery.enabled

@unwiredben
Copy link
Contributor Author

Yes, the setting already exists, but it defaults to enabled. As developers at Roku independently find this tool, we've got to constantly remind them to change this setting. That's why I wanted it to be smart about when it should be default-enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants