Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Service token is required to create RemoteAuthDataLoaderImpl #50

Closed
shurwit opened this issue Apr 28, 2022 · 0 comments · Fixed by #51
Closed

[BUG] Service token is required to create RemoteAuthDataLoaderImpl #50

shurwit opened this issue Apr 28, 2022 · 0 comments · Fixed by #51
Assignees
Labels
bug Something isn't working

Comments

@shurwit
Copy link
Collaborator

shurwit commented Apr 28, 2022

Describe the bug
The NewRemoteAuthDataLoader() function currently requires the implementing service to provide a service token to return a successfully. This should not be necessary unless functionality that requires a service token is enabled (eg. DeletedAccountsCallback).

To Reproduce
Steps to reproduce the behavior:

  1. Call NewRemoteAuthDataLoader() with configs only including the AuthServiceHost
  2. Receive error indicating that the service token is missing: error constructing data loader config: service token is missing

Expected behavior
The NewRemoteAuthDataLoader() function should return successfully even if the ServiceToken config is not provided and features requiring authorization are not configured.

@shurwit shurwit added the bug Something isn't working label Apr 28, 2022
@shurwit shurwit self-assigned this Apr 28, 2022
@shurwit shurwit changed the title [BUG] Access token is currently required to create RemoteAuthDataLoaderImpl [BUG] Service token is required to create RemoteAuthDataLoaderImpl Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant