New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CkEditor modal dialogs broken with 4.14.0 #118
Comments
I had to delete the rule manually from the module's styles/aos.min.css file, because I needed the source-view to work. Until now, there seem to be no negative effects without the rule... |
Remember that this doesn't just affect view source - it also breaks the image insert dialog. @rolandtoth - I'd submit a PR to fix this, but I honestly don't really understand why any of those |
I made those z-indexes that high because I thought that's the best way to make sure the cke overlay covers the admin header, sidebar, etc. So far it was OK, apparently recent ckeditor updates broke this workaround. I would say if removing the rule you mentioned in the first comment works then it's enough for now, until it proves the opposite :) |
Just updated to 2.0.21, please check. I could reproduce the source dialog issue but the image insert dialog was OK here. |
I can confirm that its fixed here - thank you!! |
Yep, all good again now - thanks @rolandtoth |
Hey @rolandtoth - since PW upgraded the version of CkEditor to 4.14.0 it's no longer possible to interact with Ckeditor's dialogs, such as View Source, Table, etc.
The culprit is:
.cke_dialog_background_cover{z-index:103000 !important}
in aos.min.cssThere are some other similar rules just after that one which don't seem to be a problem in my limited testing, but maybe they can all be removed or modified so they don't break things?
Thanks!
The text was updated successfully, but these errors were encountered: