Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs with ammo tracking and weight #319

Open
kewldewd666 opened this issue Aug 4, 2016 · 2 comments
Open

Bugs with ammo tracking and weight #319

kewldewd666 opened this issue Aug 4, 2016 · 2 comments

Comments

@kewldewd666
Copy link

If you adjust the amount of the linked ammo resource, it does not adjust the total weight for the character.

Also, if you set the weight of the ammo to something less than 1, like .5, weight calculations will fail after you adjust the amount of ammo. For example: create a set of 20 arrows and link them to a bow with a weight of .05 each (per PHB). Fire one arrow, and it correctly subtracts the weight. Now add the arrow back by changing the quantity from 19 to 20. Fire again, and it will subtract the ammo but not the total weight for the character.

@shdwjk
Copy link
Contributor

shdwjk commented Feb 8, 2017

What script are you using that has this bug? I'm guessing the OGL 5e Companion script, but I could see it being the 5e Shaped Companion script or the general purpose Ammo script.

@RakNoel
Copy link
Contributor

RakNoel commented Feb 9, 2018

All theese bugs appear to be fixed in the newest edition of the "5th Edition OGL by Roll20 Companion". Although looking trough the code I did manage to find a small bug with the weight where multiple ammo cunsumptions did NOT remove the correct weight. I have though added a pull-request with a fix to this small bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants