Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mutate Sidekiq payload #122

Closed
krasnoukhov opened this issue Jul 1, 2014 · 2 comments
Closed

Do not mutate Sidekiq payload #122

krasnoukhov opened this issue Jul 1, 2014 · 2 comments

Comments

@krasnoukhov
Copy link

Please take a look on this issue: mhfs/sidekiq-failures#88

Apparently your way of exception processing is quite destructive, since you're mutating context/msg variables here: https://github.com/rollbar/rollbar-gem/blob/master/lib/rollbar/sidekiq.rb

I don't think this is correct way to get rid from unwanted hash keys in terms of your exception handling. Please do not mutate, or duplicate the object before mutation.

Thank you!

@brianr
Copy link
Member

brianr commented Jul 1, 2014

Thanks for reporting! We'll look at this soon, most likely today.

@sbezboro
Copy link
Contributor

sbezboro commented Jul 9, 2014

Thanks @krasnoukhov! This was fixed in 82f6cb2 and released to rubygems as version 0.13.2. Let me know if things look OK when you get a chance to test it out

@sbezboro sbezboro closed this as completed Jul 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants