Allow specifying STDMETHODCALLTYPE to Mock methods #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC insistes that calling-convention modifiers go between the return type and function name, rather than at the end with other spec In this commit all higher-level macros just pass an empty callconv
can be used to mock COM interfaces declared using STDMETHOD(name) i.e. virtual HRESULT __stdcall name (...) .idl/.tlb do not support cvref-qualified methods, so there's no need for all the permutations of STDMETHODCALL_TYPE vs const/volatile/rvalue/etc
As these macros are expected to work with COM interfaces, we mock the IDispatch interface as a test, this brings windows headers into the test which unfourtunetly has to come before the trompeloeil.hpp header to work. It also defines "interface" as a macro, but we don't need it so we can undefine it. We also add the same test as the other MAKE_*_MOCKn macros to test the 15 variants.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
|
I'm a bit confused by this. It solves a much more specific problem than the issue you originally opened. Is there a reason for limiting the support to only ´STDMETHOD`? The change is good, BTW. Very good! Especially the docs and the extended test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new
IMPLEMENT_STDMETHOD_MOCKnandMAKE_STDMETHOD_MOCKnto allow to mock COM interfaces declared usingSTDMETHOD(name)i.e.virtual HRESULT __stdcall name (...).As .idl/.tlb do not support cvref-qualified methods, so there's no need for all the permutations of
STDMETHODCALLTYPEvs const/volatile/rvalue/etc.The new macros are implemented by extending
TROMPELOEIL_MAKE_MOCK_to take a calling convention and placing it in the correct location allowed by the microsoft compiler. This also means that the new macros only work on Windows.It also add tests and documentation for the new macros.
Closes #329