Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generate local symbol for esm import cjs instead of reference cjs namespace symbol #141

Merged
merged 4 commits into from
Nov 1, 2023
Merged

fix: generate local symbol for esm import cjs instead of reference cjs namespace symbol #141

merged 4 commits into from
Nov 1, 2023

Conversation

underfin
Copy link
Contributor

@underfin underfin commented Nov 1, 2023 •
edited

… namespace symbol

Description

close #127.
The pr fixed some bugs.

  • fix: generate local symbol for esm import cjs instead of reference cjs namespace symbol
  • fix: reExport stmt should reference self namespace symbol
  • fix: hoisted module declaration for export all declaration and export name declaration which has source imported

Test Plan

Updated.

@hyf0 hyf0 changed the title fix: generate local symbol for esm import cjs instead of reference cjs… fix: generate local symbol for esm import cjs instead of reference cjs namespace symbol Nov 1, 2023
@underfin underfin merged commit 5c53415 into main Nov 1, 2023
5 checks passed
@underfin underfin deleted the fix-cjs-namespace branch November 1, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should not generate namespace binding for ExportsKind::CommonJs
2 participants
@underfin @hyf0