feat: add OutputAsset #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2023
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
underfin
commented
Nov 12, 2023
| #[derive(Deserialize, Default, Derivative)] | ||
| #[serde(rename_all = "camelCase")] | ||
| #[derivative(Debug)] | ||
| pub struct Outputs { |
There was a problem hiding this comment.
Here serializing enum to node is difficult. It also can be implemented by serialize to a reference and get actualy value by the reference. But the performance is slow than once serializing, so here I merge data to other structures.
There was a problem hiding this comment.
But serializing once maybe is bad for performance if here have a larger data at future, we can adjust it if we have larger data at future.
hyf0
approved these changes
Nov 12, 2023
underfin
force-pushed
the
11-12-feat_add_OutputChunk_is_entry_and_facade_module_id
branch
from
63fd917
to
5dc3e74
Compare
Base automatically changed from
11-12-feat_add_OutputChunk_is_entry_and_facade_module_id
to
main
November 13, 2023 01:47
underfin
force-pushed
the
11-12-feat_add_OutputAsset
branch
from
4eabf01
to
09a0059
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan