Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ViteScannerPlugin #261

Merged
merged 5 commits into from
Nov 15, 2023
Merged

feat: add ViteScannerPlugin #261

merged 5 commits into from
Nov 15, 2023

Conversation

underfin
Copy link
Contributor

Description

Test Plan

@underfin
Copy link
Contributor Author

underfin commented Nov 14, 2023 •
edited

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@hyf0
Copy link
Member

hyf0 commented Nov 14, 2023

Hi. Amazing to see this happening. I wonder if you could change the plugin name following the convention that rollup and vite used:

and call it rolldown_plugin_xxx. If you are interested in other name conventions, sure we could have a discussion about it and see how it fits.

@underfin
Copy link
Contributor Author

I will update plugin name.

@underfin underfin mentioned this pull request Nov 14, 2023
Merged
@underfin underfin force-pushed the 11-14-feat_add_ViteScannerPlugin branch from 22c6525 to 39b0f61 Compare November 14, 2023 14:51
@underfin underfin mentioned this pull request Nov 14, 2023
Merged
@underfin underfin merged commit 3d8aff7 into main Nov 15, 2023
5 checks passed
@underfin underfin deleted the 11-14-feat_add_ViteScannerPlugin branch November 15, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@underfin @hyf0