Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add native plugin example in rust #262

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

hyf0
Copy link
Member

@hyf0 hyf0 commented Nov 14, 2023

Description

This PR is the first part of how to write a native plugin for rolldown and expose it in node binding.

Test Plan


@hyf0
Copy link
Member Author

hyf0 commented Nov 14, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@hyf0 hyf0 changed the title feat: add native plugin example feat: add native plugin example in rust Nov 14, 2023
@underfin
Copy link
Contributor

#261 I think the plugin could be a good example?

@hyf0
Copy link
Member Author

hyf0 commented Nov 14, 2023

#261 I think the plugin could be a good example?

Yeah. I look into it and found out that it's too unique to be an general purpose example.

Since it's for vite only, the way users use it and how we publish it is most likely different from the native plugins for general purpose that rolldown provide.

@underfin
Copy link
Contributor

It is a empty crate and unused, maybe adding it to development-native-plugin-guide is better?

@hyf0
Copy link
Member Author

hyf0 commented Nov 14, 2023

It is a empty crate and unused, maybe adding it to development-native-plugin-guide is better?

Thanks for the suggestion. Sorry I don't add many contexts, it's going to be used in the future.

It's part of how to write a native plugin for rolldown and expose it in node binding.

@hyf0 hyf0 force-pushed the 11-14-feat_add_native_plugin_example branch from 6bdf00f to 656711e Compare November 15, 2023 07:13
@hyf0 hyf0 merged commit 246693f into main Nov 15, 2023
5 checks passed
@hyf0 hyf0 deleted the 11-14-feat_add_native_plugin_example branch November 15, 2023 14:22
houyunlu pushed a commit that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants