Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: empty module should have ExportsKind::None #317

Merged
merged 1 commit into from
Nov 19, 2023
Merged

feat: empty module should have ExportsKind::None #317

merged 1 commit into from
Nov 19, 2023

Conversation

hyf0
Copy link
Member

@hyf0 hyf0 commented Nov 17, 2023

Description

Test Plan

@hyf0 hyf0 mentioned this pull request Nov 17, 2023
Merged
@hyf0
Copy link
Member Author

hyf0 commented Nov 17, 2023 •
edited

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@hyf0 hyf0 mentioned this pull request Nov 17, 2023
Merged
@hyf0 hyf0 force-pushed the 11-17-feat_empty_module_should_have_ExportsKind_None_ branch from 0cb68ca to eae1e57 Compare November 17, 2023 13:55
hyf0
hyf0 commented Nov 17, 2023
View reviewed changes
crates/rolldown/tests/esbuild/default/nested_common_js/artifacts.snap
@@ -8,7 +8,7 @@ input_file: crates/rolldown/tests/esbuild/default/nested_common_js
## entry_js.mjs

```js
import { __commonJS, __toESM } from "./_rolldown_runtime.mjs";
Copy link
Member Author

@hyf0 hyf0 Nov 17, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't expected to fix unnecessary import of _toESM problem in this PR :).

@hyf0 hyf0 force-pushed the 11-17-chore_tweak_visitability_of_Scanner_ branch from b73da4f to 1e61efd Compare November 18, 2023 03:28
Base automatically changed from 11-17-chore_tweak_visitability_of_Scanner_ to main November 18, 2023 03:30
@hyf0 hyf0 force-pushed the 11-17-feat_empty_module_should_have_ExportsKind_None_ branch from eae1e57 to dd8e8b6 Compare November 18, 2023 03:32
This was referenced Nov 18, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@hyf0
Copy link
Member Author

hyf0 commented Nov 19, 2023 •
edited

Merge activity

  • Nov 19, 6:40 AM: @hyf0 started a stack merge that includes this pull request via Graphite.
  • Nov 19, 6:40 AM: @hyf0 merged this pull request with Graphite.

@hyf0 hyf0 merged commit b15ff14 into main Nov 19, 2023
6 checks passed
@hyf0 hyf0 deleted the 11-17-feat_empty_module_should_have_ExportsKind_None_ branch November 19, 2023 11:40
This was referenced Nov 19, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underfin underfin underfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hyf0 @underfin