fix: ensure valid output for import the same cjs twice #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyf0
changed the title
This was referenced Nov 18, 2023
hyf0
changed the title
hyf0
force-pushed
the
11-18-fix_ensure_valid_output_for_import_the_same_cjs_twice
branch
3 times, most recently
from
b207cd9
to
3650c1e
Compare
This was referenced Nov 19, 2023
underfin
reviewed
Nov 19, 2023
| self.idx, | ||
| self | ||
| .symbol_table | ||
| .create_symbol(format!("import_{importee_repr}").into(), self.scope.root_scope_id()), |
There was a problem hiding this comment.
Here is better if check the symbol is already created, it will reduce one symbol deconfilct.
There was a problem hiding this comment.
Yeah. I saw that. Currently, we would create symbol for each ImportReocrd, this is how esbuild does it too. I'm thinking how to optimize it, but that's another story :).
hyf0
force-pushed
the
11-18-refactor_create_wrapper_ref_after_wrapping
branch
from
4ad5249
to
916105e
Compare
|
Cool! |
underfin
approved these changes
Nov 19, 2023
Base automatically changed from
11-18-refactor_create_wrapper_ref_after_wrapping
to
main
November 19, 2023 11:44
hyf0
force-pushed
the
11-18-fix_ensure_valid_output_for_import_the_same_cjs_twice
branch
from
3650c1e
to
18c85da
Compare
hyf0
deleted the
11-18-fix_ensure_valid_output_for_import_the_same_cjs_twice
branch
This was referenced Nov 19, 2023
hyf0
added a commit
that referenced
this pull request
Nov 22, 2023
…#351) <!-- Thank you for contributing! --> ### Description Rendering imports from external modules has same problem in #323, but the problem is hidden by the old merging behavior. <!-- Please insert your description here and provide especially info about the "what" this PR is solving --> ### Test Plan <!-- e.g. is there anything you'd like reviewers to focus on? --> ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://hyrious.me/esbuild-repl/?version=0.18.19&b=e%00entry.js%00import+%7B+a+%7D+from+%27.%2Ffile%27%0Aconsole.log%28a%29%0Aimport+%7B+a+as+a2+%7D+from+%27.%2Ffile%27%0Aconsole.log%28a2%29&b=%00file.js%00module.exports.a+%3D+1&o=--bundle+--outdir%3D%22%2F%22+--format%3Desm+--splitting
This PR also remove concept
ReExport. AReExportis a combination ofLocalExportandNamedExport. This reduces complexity of dealing withReExport.Test Plan