fix: A Symbol should only be declared in one chunk
#338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
hyf0
changed the title
Symbol should not be declared twiceSymbol should only be declared in one chunk
hyf0
commented
Nov 20, 2023
| @@ -116,11 +116,13 @@ impl<'a> BundleStage<'a> { | |||
| Module::Normal(module) => { | |||
| for stmt_info in module.stmt_infos.iter() { | |||
| for declared in &stmt_info.declared_symbols { | |||
| // TODO: pass debug_assert!(self.graph.symbols.get(*declared).chunk_id.is_none()); | |||
| // FIXME: I don't think this is correct, even though the assigned chunk_id is the same as the current chunk_id. | |||
| // A declared symbol should only be processed once. | |||
There was a problem hiding this comment.
A declared symbol is expected to see more than once.
var outsideVar = 'outside';
let outsideLet = 'outside';
try {
throw new Error();
} catch (e) {
var outsideVar = 'inside';
let outsideLet = 'inside';
var insideVar = 'inside';
}
assert.equal(outsideVar, 'inside');
assert.equal(outsideLet, 'outside');
assert.equal(insideVar, 'inside');
underfin
approved these changes
Nov 20, 2023
Base automatically changed from
11-20-fix_allow_cjs_to_be_both_entry_and_dependency
to
main
November 20, 2023 07:17
hyf0
force-pushed
the
11-20-fix_A_Symbol_should_not_be_declared_twice
branch
from
d0a7f37
to
1c2fc5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan