fix: conflict between imported and local binding #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
hyf0
force-pushed
the
11-22-fix_conflict_between_imported_and_local_binding
branch
from
3b9c675
to
eff27a1
Compare
underfin
reviewed
Nov 22, 2023
| self.imports_from_other_chunks.iter().flat_map(|(_, items)| items.iter()).for_each(|item| { | ||
| renamer.add_top_level_symbol(item.import_ref); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Could you explain it why does not affect? If add_top_level_symbol order will cause some error, maybe move it up also has some side effects.
There was a problem hiding this comment.
maybe move it up also has some side effects.
Yeah. You are totally right. Moving up fix the problem in #355.
To avoid conflict with imported names, we should first reserve the names of imports, but the old code doesn't do it first instead do it secondly, so it has no effect.
This was referenced Nov 22, 2023
underfin
approved these changes
Nov 22, 2023
hyf0
deleted the
11-22-fix_conflict_between_imported_and_local_binding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #355
Test Plan