Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): rendering runtime module in snapshot testing #375

Merged

Conversation

hyf0
Copy link
Member

@hyf0 hyf0 commented Nov 23, 2023

Description

Test Plan


@hyf0 hyf0 force-pushed the 11-23-feat_rust_rendering_runtime_module_in_snapshot_testing branch from 5daaca2 to bf15a55 Compare November 23, 2023 08:44
@underfin
Copy link
Contributor

The runtime code is larger, it is difficult to review, maybe we can use another idea to exclude it. I see esbuild snapshot also hasn't runtime code.

@hyf0
Copy link
Member Author

hyf0 commented Nov 23, 2023

The runtime code is larger, it is difficult to review, maybe we can use another idea to exclude it. I see esbuild snapshot also hasn't runtime code.

This tests the behaviors of treeshaking with runtime module. Feel free to open a team meeting to discuss this PR.

@underfin
Copy link
Contributor

Track here #390.

@underfin
Copy link
Contributor

underfin commented Nov 25, 2023

Other we need to add tree shaking option to enable the behaviors of treeshaking with module. You can do it at new pr.

Copy link
Member

Boshen commented Nov 27, 2023

Merge activity

  • Nov 26, 10:26 PM: @Boshen started a stack merge that includes this pull request via Graphite.
  • Nov 26, 10:38 PM: Graphite couldn't merge this PR because it had conflicts with the trunk branch.

@Boshen Boshen force-pushed the 11-23-feat_improve_side-effect_detection_of_MemberExpression_ branch from 76168f9 to 0e41b6a Compare November 27, 2023 03:34
Base automatically changed from 11-23-feat_improve_side-effect_detection_of_MemberExpression_ to main November 27, 2023 03:38
@hyf0 hyf0 force-pushed the 11-23-feat_rust_rendering_runtime_module_in_snapshot_testing branch from 193fd16 to 424651e Compare November 27, 2023 05:15
@underfin underfin merged commit 3cb39a2 into main Nov 28, 2023
6 checks passed
@underfin underfin deleted the 11-23-feat_rust_rendering_runtime_module_in_snapshot_testing branch November 28, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants