-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: should correctly render export default xxx
#377
Merged
underfin
merged 5 commits into
main
from
11-23-fix_should_correctly_render_export_default_xxx_
Nov 29, 2023
Merged
fix: should correctly render export default xxx
#377
underfin
merged 5 commits into
main
from
11-23-fix_should_correctly_render_export_default_xxx_
Nov 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 23, 2023
Merged
underfin
approved these changes
Nov 23, 2023
This was referenced Nov 23, 2023
Merge activity
|
hyf0
force-pushed
the
11-23-feat_rust_rendering_runtime_module_in_snapshot_testing
branch
from
November 27, 2023 05:15
193fd16
to
424651e
Compare
hyf0
force-pushed
the
11-23-fix_should_correctly_render_export_default_xxx_
branch
from
November 27, 2023 05:15
48755de
to
cd29a2e
Compare
Base automatically changed from
11-23-feat_rust_rendering_runtime_module_in_snapshot_testing
to
main
November 28, 2023 15:38
underfin
force-pushed
the
11-23-fix_should_correctly_render_export_default_xxx_
branch
from
November 29, 2023 02:04
cd29a2e
to
7c2f0b7
Compare
underfin
deleted the
11-23-fix_should_correctly_render_export_default_xxx_
branch
November 29, 2023 02:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #376.
The bug is caused by rendering
export default xxx
https://github.com/rolldown-rs/rolldown/blame/5b76d947e6272e68a1fabd9361bb5bb2e651846d/crates/rolldown/src/bundler/visitors/esm_source_render.rs#L74-L78
without considering the special behaviors in scanning
https://github.com/rolldown-rs/rolldown/blame/5b76d947e6272e68a1fabd9361bb5bb2e651846d/crates/rolldown/src/bundler/visitors/scanner.rs#L223-L237
Test Plan