Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another way is to have a special
ModuleTaskForRuntime
to deal with the special logic of runtime module.I haven't think through which way is better. Let's change it later.
Originally posted by @hyf0 in #37 (comment)
We should have should have different kind of module task to deal with different module. This prevent mixing up code for different module.
For example, runtime module would never call
load
orresolve
hooks.Test Plan