Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add RuntimeNormalModuleTask #40

Merged
merged 2 commits into from
Oct 12, 2023
Merged

feat: add RuntimeNormalModuleTask #40

merged 2 commits into from
Oct 12, 2023

Conversation

hyf0
Copy link
Member

@hyf0 hyf0 commented Oct 10, 2023

Description

          I'm intending to not include `runtime` module as the part of making module graph. In this way, we don't need to write such code.

Another way is to have a special ModuleTaskForRuntime to deal with the special logic of runtime module.

I haven't think through which way is better. Let's change it later.

Originally posted by @hyf0 in #37 (comment)


We should have should have different kind of module task to deal with different module. This prevent mixing up code for different module.

For example, runtime module would never call load or resolve hooks.

Test Plan


@hyf0 hyf0 changed the title feat: should have different kind of module task WIP: feat: should have different kind of module task Oct 10, 2023
@hyf0 hyf0 changed the title WIP: feat: should have different kind of module task wip: should have different kind of module task Oct 10, 2023
@hyf0 hyf0 changed the title wip: should have different kind of module task feat: should have different kind of module task Oct 12, 2023
@hyf0 hyf0 changed the title feat: should have different kind of module task feat: add RuntimeNormalModuleTask Oct 12, 2023
@hyf0 hyf0 merged commit 2401386 into main Oct 12, 2023
3 checks passed
@hyf0 hyf0 deleted the hyf_32094829034 branch November 5, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant