Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(binding): only panic in the main thread #507

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

hyf0
Copy link
Member

@hyf0 hyf0 commented Mar 9, 2024

Remove panics from tokio workers

@Brooooooklyn Brooooooklyn changed the title feat: only panic in the main thread fix(binding): only panic in the main thread Mar 9, 2024
@Brooooooklyn Brooooooklyn force-pushed the hyf_refactor/use-threadsafe-function branch from 64b9eda to 7c93584 Compare March 9, 2024 15:22
@Brooooooklyn Brooooooklyn changed the base branch from refactor/use-threadsafe-function to main March 9, 2024 15:22
Copy link
Contributor

Brooooooklyn commented Mar 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@Brooooooklyn Brooooooklyn changed the base branch from main to refactor/use-threadsafe-function March 9, 2024 15:24
@Brooooooklyn Brooooooklyn force-pushed the hyf_refactor/use-threadsafe-function branch from 7c93584 to 752e5f2 Compare March 9, 2024 15:24
@Brooooooklyn Brooooooklyn force-pushed the refactor/use-threadsafe-function branch 3 times, most recently from bbffed2 to d5dd8ff Compare March 20, 2024 15:17
@Brooooooklyn Brooooooklyn force-pushed the hyf_refactor/use-threadsafe-function branch from cb94324 to 5ddf39e Compare March 20, 2024 15:21
Base automatically changed from refactor/use-threadsafe-function to main March 20, 2024 15:25
@Brooooooklyn Brooooooklyn force-pushed the hyf_refactor/use-threadsafe-function branch from 5ddf39e to caf14bd Compare March 20, 2024 15:29
Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit caf14bd
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/65fb00df8f892b0008b1aa1a

Copy link
Contributor

Brooooooklyn commented Mar 20, 2024

Merge activity

  • Mar 20, 11:30 AM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 20, 11:35 AM EDT: @Brooooooklyn merged this pull request with Graphite.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 60.41667% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 78.71%. Comparing base (8037b5b) to head (caf14bd).

Files Patch % Lines
...s/rolldown/src/module_loader/normal_module_task.rs 64.28% 15 Missing ⚠️
crates/rolldown/src/module_loader/module_loader.rs 33.33% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
- Coverage   78.81%   78.71%   -0.10%     
==========================================
  Files         138      138              
  Lines        6574     6601      +27     
==========================================
+ Hits         5181     5196      +15     
- Misses       1393     1405      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Brooooooklyn Brooooooklyn merged commit d844125 into main Mar 20, 2024
18 checks passed
@Brooooooklyn Brooooooklyn deleted the hyf_refactor/use-threadsafe-function branch March 20, 2024 15:35
Copy link

codspeed-hq bot commented Mar 20, 2024

CodSpeed Performance Report

Merging #507 will not alter performance

Comparing hyf_refactor/use-threadsafe-function (caf14bd) with main (8037b5b)

Summary

✅ 6 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants