Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve side effect detection #534

Merged
merged 9 commits into from
Mar 10, 2024
Merged

feat: improve side effect detection #534

merged 9 commits into from
Mar 10, 2024

Conversation

Demivan
Copy link
Contributor

@Demivan Demivan commented Mar 10, 2024

Description

Implement detecting side effects in ParenthesizedExpression, SequenceExpression and LogicalExpression.

Test Plan

Added tests

@netlify Netlify
Copy link

netlify bot commented Mar 10, 2024 •
edited

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 313dacf
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/65ede185ed623e0008811ba9

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 10, 2024

CodSpeed Performance Report

Merging #534 will not alter performance

Comparing Demivan:expr-side-effects (313dacf) with main (2266c25)

Summary

✅ 4 untouched benchmarks

hyf0
hyf0 approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@hyf0 hyf0 merged commit f38e7a0 into rolldown:main Mar 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Demivan @hyf0