Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: implement ConcatSource #611

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

underfin
Copy link
Contributor

@underfin underfin commented Mar 19, 2024

Description

implement ConcatSource instead of concat_sourcemap.

Test Plan

Not need.

Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit c64261b
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/65f910036151a400082524d1

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 64.51613% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 78.63%. Comparing base (7ae8435) to head (c64261b).
Report is 3 commits behind head on main.

Files Patch % Lines
crates/rolldown_sourcemap/src/concat_sourcemap.rs 59.57% 19 Missing ⚠️
crates/rolldown/src/chunk/mod.rs 80.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
- Coverage   78.95%   78.63%   -0.33%     
==========================================
  Files         142      142              
  Lines        6510     6599      +89     
==========================================
+ Hits         5140     5189      +49     
- Misses       1370     1410      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@underfin underfin merged commit a05eb3d into main Mar 19, 2024
19 of 20 checks passed
@underfin underfin deleted the refactor_concat_sourcemap branch March 19, 2024 07:33
@hyf0
Copy link
Member

hyf0 commented Mar 19, 2024

@underfin I ran rust benchmark locally with this PR and get

Benchmarking rolldown benchmark/threejs-sourcemap: Collecting 20 samples in estimated 332.45 s (20 iterations)

This break benchmark action. Do you have time fix it?

hyf0 added a commit that referenced this pull request Mar 19, 2024
hyf0 added a commit that referenced this pull request Mar 19, 2024
hyf0 added a commit that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants