feat: expose cwd in input options
#692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rolldown-rs canceled.
|
|
@hyf0 I refactored rolldown tests to use |
hyf0
reviewed
Mar 29, 2024
| @@ -4,7 +4,8 @@ import { expect } from 'vitest' | |||
| import { getOutputChunkNames } from '@tests/utils' | |||
|
|
|||
| const config: RollupOptions = { | |||
| input: [path.join(__dirname, 'main.js'), path.join(__dirname, 'entry.js')], | |||
| input: ['main.js', 'entry.js'], | |||
| cwd: __dirname, | |||
There was a problem hiding this comment.
Since you already pass cwd in packages/rolldown/tests/fixture.test.ts, this is unnessary to pass it again.
hyf0
reviewed
Mar 29, 2024
There was a problem hiding this comment.
You could also remove this line
Rolldown will emit to <CWD>/dist by default.
Exposes `cwd` prop in `InputOptions` and updates rolldown tests to leverage it. Closes rolldown#687
jwnx
force-pushed
the
jwnx/feat/expose-cwd-in-input-options
branch
from
3a36c55
to
0dffe3c
Compare
jwnx
commented
Mar 29, 2024
There was a problem hiding this comment.
@hyf0 I was able to remove a lot of path manipulation from this file and tests are passing just fine. Let me know if you think we should keep the old code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
cwdprop inInputOptionsand updates rolldown tests toleverage it. Closes #687