-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add footer output option #693
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
CodSpeed Performance ReportMerging #693 will not alter performanceFalling back to comparing Summary
|
Thank you. |
thanks! |
RolldownOutput, | ||
RolldownOutputChunk, | ||
} from '../../../../src' | ||
import { expect } from 'vitest' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be import { ... } from 'rolldown'
directly. And you don't need to import these types with using defineTest
. Types will be inferred automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will fix these .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I create an issue for this. Not just the banner test, some other tests also have this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
Description
add
footer
output option based onbanner
optionTest Plan