fix(cli): user-friendly console output of chunk information #727
+93
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rolldown-rs canceled.
|
kazupon
commented
Apr 2, 2024
| @@ -14,13 +19,133 @@ export async function bundle(configExport: RolldownConfigExport) { | |||
| } | |||
|
|
|||
| async function bundleInner(options: RolldownOptions) { | |||
| const start = performance.now() | |||
| const dir = options.output?.dir ?? 'dist' | |||
There was a problem hiding this comment.
The default for dir is held by the Rust side.
I think we need a mechanism to share dir defaults between JS side and Rust side.
If we change this value on either side, it may not work.
There was a problem hiding this comment.
For non-gziped size, you should able to get them in the returned value of write or generate. However, this might still slow down the performance potentially if we didn't do the optimization in #696.
I suggest we now only print non-gized sizes. It should solves
- the performance problem of large project
- not knowing
default for dirproblem
hyf0
reviewed
Apr 2, 2024
|
I have dropped the display gzip size feature. |
hyf0
force-pushed
the
fix/friendly-output-info
branch
from
6d2ae85
to
400ca6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The rolldown CLI only outputs the following exit message and time when a build is executed with the command.
This PR user-friendly output to console like vite.
Test Plan