-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust): don't generate sourcemap for virtual modules #733
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
4c2e30b
to
41c9f94
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
==========================================
+ Coverage 79.50% 79.53% +0.02%
==========================================
Files 149 149
Lines 6803 6811 +8
==========================================
+ Hits 5409 5417 +8
Misses 1394 1394 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #733 will not alter performanceComparing Summary
|
Shocked. How come this PR pass the windows ci. |
The error is flashing... |
Description
The runtime module and module which path starts with
\0
shouldn't generate sourcemap. Ref see https://github.com/rollup/rollup/blob/master/src/Module.ts#L279.Test Plan
Updated test.