Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): don't generate sourcemap for virtual modules #733

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

underfin
Copy link
Contributor

@underfin underfin commented Apr 3, 2024

Description

The runtime module and module which path starts with \0 shouldn't generate sourcemap. Ref see https://github.com/rollup/rollup/blob/master/src/Module.ts#L279.

Test Plan

Updated test.


Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 1b0e30f
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/660d0ddf1f7fd10008957beb

@underfin underfin force-pushed the virtual-module-skip-sourcemap branch from 4c2e30b to 41c9f94 Compare April 3, 2024 07:42
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.53%. Comparing base (d8fc0c6) to head (41c9f94).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
+ Coverage   79.50%   79.53%   +0.02%     
==========================================
  Files         149      149              
  Lines        6803     6811       +8     
==========================================
+ Hits         5409     5417       +8     
  Misses       1394     1394              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/rolldown/src/chunk/mod.rs Outdated Show resolved Hide resolved
crates/rolldown_common/src/module/normal_module.rs Outdated Show resolved Hide resolved
Copy link

codspeed-hq bot commented Apr 3, 2024

CodSpeed Performance Report

Merging #733 will not alter performance

Comparing virtual-module-skip-sourcemap (1b0e30f) with main (06cf72d)

Summary

✅ 6 untouched benchmarks

@hyf0
Copy link
Member

hyf0 commented Apr 3, 2024

Shocked. How come this PR pass the windows ci.

@hyf0 hyf0 changed the title feat: skip runtime module and virtual module sourcemap feat: don't generate sourcemap for virtual modules Apr 3, 2024
@hyf0 hyf0 changed the title feat: don't generate sourcemap for virtual modules feat(rust): don't generate sourcemap for virtual modules Apr 3, 2024
@underfin
Copy link
Contributor Author

underfin commented Apr 3, 2024

Shocked. How come this PR pass the windows ci.

The error is flashing...

@hyf0 hyf0 merged commit b546e8f into main Apr 3, 2024
18 of 19 checks passed
@hyf0 hyf0 deleted the virtual-module-skip-sourcemap branch April 3, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants