Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add InputOptions#platform #751

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

hyf0
Copy link
Member

@hyf0 hyf0 commented Apr 4, 2024

Description

Copy link
Member Author

hyf0 commented Apr 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 65c4cd8
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/660f2ca4cdc80f000857db9e

@hyf0 hyf0 marked this pull request as ready for review April 4, 2024 22:42
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 65c4cd8 Previous: 5e25f31 Ratio
threejs10x 345.63 ms / ops 360.40 ms / ops 0.96
threejs10x-sourcemap 449.50 ms / ops 459.35 ms / ops 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 79.62%. Comparing base (8918e05) to head (65c4cd8).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/rolldown/src/options/types/platform.rs 0.00% 7 Missing ⚠️
...own_binding/src/utils/normalize_binding_options.rs 0.00% 6 Missing ⚠️
crates/rolldown_binding_wasm/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
- Coverage   79.73%   79.62%   -0.11%     
==========================================
  Files         127      128       +1     
  Lines        6558     6568      +10     
==========================================
+ Hits         5229     5230       +1     
- Misses       1329     1338       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyf0 hyf0 merged commit 97ea4b6 into main Apr 4, 2024
22 of 24 checks passed
@hyf0 hyf0 deleted the 04-05-feat_add_inputoptions_platform_ branch April 4, 2024 22:47
Copy link

codspeed-hq bot commented Apr 4, 2024

CodSpeed Performance Report

Merging #751 will not alter performance

Comparing 04-05-feat_add_inputoptions_platform_ (65c4cd8) with main (8918e05)

Summary

✅ 6 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant