Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support render chunk hook return sourcemap #776

Merged
merged 3 commits into from
Apr 7, 2024
Merged

Conversation

underfin
Copy link
Contributor

@underfin underfin commented Apr 7, 2024

Description

Copy link

netlify bot commented Apr 7, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 12e5fbd
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66124eb6f68ec4000830c729

Copy link

netlify bot commented Apr 7, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit b9d9aa5
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66124f49c1641c000856d9d3

@underfin underfin changed the title feat: support render chunk return sourcemap feat: support render chunk hook return sourcemap Apr 7, 2024
Copy link

codspeed-hq bot commented Apr 7, 2024

CodSpeed Performance Report

Merging #776 will not alter performance

Comparing render-chunk-map (b9d9aa5) with main (e5a81c0)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 48.07692% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 80.75%. Comparing base (2c84963) to head (b9d9aa5).
Report is 4 commits behind head on main.

Files Patch % Lines
...s/plugin/types/binding_hook_render_chunk_output.rs 0.00% 10 Missing ⚠️
crates/rolldown_sourcemap/src/lib.rs 9.09% 10 Missing ⚠️
...s/rolldown_binding/src/options/plugin/js_plugin.rs 0.00% 4 Missing ⚠️
...s/rolldown_plugin/src/plugin_driver/build_hooks.rs 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
+ Coverage   80.23%   80.75%   +0.52%     
==========================================
  Files         127      127              
  Lines        6672     6642      -30     
==========================================
+ Hits         5353     5364      +11     
+ Misses       1319     1278      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyf0 hyf0 merged commit 0d4c2d5 into main Apr 7, 2024
22 of 23 checks passed
@hyf0 hyf0 deleted the render-chunk-map branch April 7, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants