Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust/resolver): use selected resolver instead of the default one #780

Conversation

hyf0
Copy link
Member

@hyf0 hyf0 commented Apr 7, 2024

Description

Copy link
Member Author

hyf0 commented Apr 7, 2024

Copy link

codspeed-hq bot commented Apr 7, 2024

CodSpeed Performance Report

Merging #780 will not alter performance

Comparing 04-07-fix_rust_resolver_use_selected_resolver_instead_of_the_default_one (9def790) with main (9267113)

Summary

✅ 6 untouched benchmarks

Copy link
Member Author

hyf0 commented Apr 7, 2024

Merge activity

  • Apr 7, 10:36 AM EDT: @hyf0 started a stack merge that includes this pull request via Graphite.
  • Apr 7, 10:37 AM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 7, 10:38 AM EDT: @hyf0 merged this pull request with Graphite.

Base automatically changed from 04-07-refactor_rust_use_walk_xxx_api_to_traverse_ast to main April 7, 2024 14:36
@hyf0 hyf0 force-pushed the 04-07-fix_rust_resolver_use_selected_resolver_instead_of_the_default_one branch from 8171810 to 9def790 Compare April 7, 2024 14:36
Copy link

netlify bot commented Apr 7, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 9def790
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6612af7ac06fa6000838ddac

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@9267113). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #780   +/-   ##
=======================================
  Coverage        ?   80.90%           
=======================================
  Files           ?      127           
  Lines           ?     6588           
  Branches        ?        0           
=======================================
  Hits            ?     5330           
  Misses          ?     1258           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyf0 hyf0 merged commit 226df5b into main Apr 7, 2024
20 of 21 checks passed
@hyf0 hyf0 deleted the 04-07-fix_rust_resolver_use_selected_resolver_instead_of_the_default_one branch April 7, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant