feat: implement some expr side effect detector #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rolldown-rs canceled.
|
CodSpeed Performance ReportMerging #807 will not alter performanceComparing Summary
|
hyf0
requested changes
Apr 9, 2024
hyf0
requested changes
Apr 9, 2024
woai3c
force-pushed
the
side_effect_detector
branch
from
a73f5b6
to
931cdd4
Compare
|
@hyf0 The code for By the way, I'd like to contribute more to Rolldown. Currently, I usually look for TODO comments in the code and then implement them. However, some TODOs seem quite challenging to implement. Could you give me some advice on what aspects of Rolldown I should focus on to contribute more effectively? |
IWANABETHATGUY
changed the title
hyf0
force-pushed
the
side_effect_detector
branch
from
06c7054
to
6dbba6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have enhanced some of the code for side-effect detection in expressions, but there are still parts that I'm currently unsure how to implement.