Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rust): only derive deserialize on BundlerOptions in testing #880

Merged
merged 6 commits into from
Apr 17, 2024
Merged

feat(rust): only derive deserialize on BundlerOptions in testing #880

merged 6 commits into from
Apr 17, 2024

Conversation

oddguan
Copy link
Contributor

@oddguan oddguan commented Apr 16, 2024

Added a feature gate called "serialize" for enabling converting between JSON and BundlerOptions in test envs.

@netlify Netlify
Copy link

netlify bot commented Apr 16, 2024 •
edited

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 6cd79a1
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/661f5c72e0ce870008761efd

@oddguan oddguan changed the title perf(bundler-options): add feature gate to reduce production bundle size perf(bundler-options): add feature gate to reduce production bundle size #786 Apr 16, 2024
@oddguan oddguan changed the title perf(bundler-options): add feature gate to reduce production bundle size #786 perf(bundler-options): add feature gate to reduce production bundle size !786 Apr 16, 2024
@oddguan oddguan changed the title perf(bundler-options): add feature gate to reduce production bundle size !786 perf(bundler-options): add feature gate to reduce production bundle size Apr 16, 2024
@oddguan
Copy link
Contributor Author

oddguan commented Apr 16, 2024

This PR is for issue #786

hyf0
hyf0 requested changes Apr 16, 2024
View reviewed changes
crates/rolldown_common/src/inner_bundler_options/mod.rs Outdated Show resolved Hide resolved
crates/rolldown_common/Cargo.toml Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
justfile Outdated Show resolved Hide resolved
@hyf0 hyf0 self-assigned this Apr 16, 2024
@hyf0 hyf0 linked an issue Apr 16, 2024 that may be closed by this pull request
Reduce binary sizes by removing derived macros which is unnecessary in production #786
Closed
@oddguan oddguan requested a review from hyf0 April 16, 2024 08:44
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 16, 2024 •
edited

CodSpeed Performance Report

Merging #880 will not alter performance

Comparing oddguan:feature_serialize (6cd79a1) with main (da45d40)

Summary

✅ 6 untouched benchmarks

@hyf0
Copy link
Member

hyf0 commented Apr 16, 2024 •
edited

You forgot about this one and others:

rolldown/crates/rolldown_common/src/inner_bundler_options/types/resolve_options.rs

Line 6 in 07a175b

#[derive(Debug, Default, Deserialize, JsonSchema)]

...

Please make sure all depended types by BundleOptions are changed too.

@oddguan
Copy link
Contributor Author

oddguan commented Apr 16, 2024

You forgot about this one and others:

rolldown/crates/rolldown_common/src/inner_bundler_options/types/resolve_options.rs

Line 6 in 07a175b

#[derive(Debug, Default, Deserialize, JsonSchema)]

...

Please make sure all depended types by BundleOptions are changed too.

Looked into the original PR #762 and found some leftover files. Not sure if I covered all. Please check thanks

@oddguan
Copy link
Contributor Author

oddguan commented Apr 16, 2024

@hyf0 needs approval on workflows

hyf0
hyf0 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hyf0 hyf0 enabled auto-merge (squash) April 17, 2024 05:23
@hyf0 hyf0 disabled auto-merge April 17, 2024 05:23
@hyf0 hyf0 changed the title perf(bundler-options): add feature gate to reduce production bundle size feat(rust): only derive deserialize on BundlerOptions in testing Apr 17, 2024
@hyf0 hyf0 enabled auto-merge (squash) April 17, 2024 05:24
@hyf0 hyf0 merged commit 06df20d into rolldown:main Apr 17, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

@hyf0 hyf0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce binary sizes by removing derived macros which is unnecessary in production
2 participants
@oddguan @hyf0