-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: buildEnd hook handle error #902
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
} | ||
} | ||
self.remaining -= 1; | ||
} | ||
|
||
assert!(panic_errors.is_empty(), "Panics occurred during module loading: {panic_errors:?}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this using Result
instead of it to avoid panic at here.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
=======================================
Coverage 77.95% 77.96%
=======================================
Files 137 137
Lines 6890 6879 -11
=======================================
- Hits 5371 5363 -8
+ Misses 1519 1516 -3 ☔ View full report in Codecov by Sentry. |
Benchmark Results
|
CodSpeed Performance ReportMerging #902 will not alter performanceComparing Summary
|
Description