Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: buildEnd hook handle error #902

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: buildEnd hook handle error #902

merged 1 commit into from
Apr 17, 2024

Conversation

underfin
Copy link
Contributor

Description

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit e3910d9
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/661fc284e49ce400080d89f6

}
}
self.remaining -= 1;
}

assert!(panic_errors.is_empty(), "Panics occurred during module loading: {panic_errors:?}");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this using Result instead of it to avoid panic at here.

@underfin underfin enabled auto-merge (squash) April 17, 2024 12:40
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.96%. Comparing base (b9c9181) to head (e3910d9).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/rolldown/src/module_loader/module_loader.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #902   +/-   ##
=======================================
  Coverage   77.95%   77.96%           
=======================================
  Files         137      137           
  Lines        6890     6879   -11     
=======================================
- Hits         5371     5363    -8     
+ Misses       1519     1516    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@underfin underfin merged commit bc8e9ab into main Apr 17, 2024
28 checks passed
@underfin underfin deleted the fix-build-end-error branch April 17, 2024 12:43
Copy link

Benchmark Results

group                                      baseline                               pr
-----                                      --------                               --
rolldown benchmark/threejs-bundle          1.02     29.5±0.21ms        ? ?/sec    1.00     29.0±0.32ms        ? ?/sec
rolldown benchmark/threejs-scan            1.03     20.8±1.37ms        ? ?/sec    1.00     20.2±0.47ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.02     41.5±0.59ms        ? ?/sec    1.00     40.5±0.39ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.01    313.8±6.92ms        ? ?/sec    1.00    310.9±2.20ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.01    201.5±0.88ms        ? ?/sec    1.00    199.3±1.79ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.00    407.5±8.88ms        ? ?/sec    1.00    407.0±7.67ms        ? ?/sec

Copy link

codspeed-hq bot commented Apr 17, 2024

CodSpeed Performance Report

Merging #902 will not alter performance

Comparing fix-build-end-error (e3910d9) with main (b9c9181)

Summary

✅ 6 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants