-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: workaround vite package build error #28
base: rolldown-optimizer
Are you sure you want to change the base?
chore: workaround vite package build error #28
Conversation
The latest rolldown should be |
Thanks for the heads up! I'll test that with 0.12.1 |
Starting to check tests failure. Let me put some notes here playground/externalbefore//
// node_modules/.vite/deps/@vitejs_test-dep-that-requires.js?v=7ce498d7
//
import {
require_vue
} from "/node_modules/.vite/deps/chunk-ACQTEB6D.js?v=d821959b";
import {
require_slash
} from "/node_modules/.vite/deps/chunk-PNJKIXPP.js?v=d821959b";
// ../../node_modules/.pnpm/@vitejs+test-dep-that-requires@file+playground+external+dep-that-requires_typescript@5.2.2/node_modules/@vitejs/test-dep-that-requires/index.js
var { version } = require_vue();
var slash3 = require_slash();
document.querySelector("#required-vue-version").textContent = version;
document.querySelector("#required-slash3-exists").textContent = !!slash3("foo/bar");
//# sourceMappingURL=@vitejs_test-dep-that-requires.js.map
//
// node_modules/.vite/deps/chunk-ACQTEB6D.js
//
import {
__commonJS
} from "./chunk-PNJKIXPP.js";
// vite:cjs-external-facade:vue
import * as m from "vue";
var require_vue = __commonJS({
"vite:cjs-external-facade:vue"(exports, module) {
module.exports = m;
}
});
export {
require_vue
}; after
import { require_slash_index } from "/node_modules/.vite/deps/slash_index--Dt2Pc4V.js?v=31538b99";
//#region ../../node_modules/.pnpm/@vitejs+test-dep-that-requires@file+playground+external+dep-that-requires_typescript@5.2.2/node_modules/@vitejs/test-dep-that-requires/index.js
const { version } = require('vue');
const slash3 = require_slash_index();
document.querySelector('#required-vue-version').textContent = version;
document.querySelector('#required-slash3-exists').textContent = !!slash3('foo/bar');
//#endregion
//# sourceMappingURL=@vitejs_test-dep-that-requires.js.map playground/dynamic-import
beforeimport("/@fs/home/hiroshi/code/others/vite/node_modules/.pnpm/@vitejs+test-pkg@file+playground+dynamic-import+pkg/node_modules/@vitejs/test-pkg/pkg.css"); after// node_modules/.vite/deps/@vitejs_test-pkg.js
// not transformed
import('./pkg.css');
// then after vite import analysis rewrite
import("/node_modules/.vite/deps/pkg.css?v=b4888b04") playground/ssr-noexternalError during ssr optimizeDeps. It looks like this is because of
playground/ssr-depsProbably a same error as playground/tsconfig-jsonRolldown is throwing an error during deps scan since it uses esbuild's transform here but without user tsconfig which enables vite/packages/vite/src/node/optimizer/scan.ts Lines 1023 to 1025 in 9fdf94a
playground/aliasThere's an error during deps optimization
It seems this alias is the problem. vite/playground/alias/vite.config.js Lines 25 to 26 in c5f38bf
|
Description
In addition to rolldown/rolldown#1642, it looks like
replaceConfusingTypeNames
is messing with vite package build. I haven't checked the error in a detail, but maybe it's okay to skip it for starter?I temporary included a patch for
binding.d.ts
type error in the PR to verifypnpm build
succeeds.