Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring a threshold for the pwned passwords constraint #22

Closed
stof opened this issue May 2, 2018 · 3 comments
Closed

Allow configuring a threshold for the pwned passwords constraint #22

stof opened this issue May 2, 2018 · 3 comments
Labels

Comments

@stof
Copy link
Contributor

stof commented May 2, 2018

Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? yes

Currently, the constraint will reject any password found at least once on pwnedpasswords.com. While this is indeed the safest behavior (and so a sensible default), it means blocking half a billion passwords currently.
The blog post announcing the launch of the v2 (which is used here) recognizes this usability nightmare, and explains that this is the reason why a count is provided for each password: https://www.troyhunt.com/ive-just-launched-pwned-passwords-version-2/#eachpasswordnowhasacountnexttoit

I would be great to allow configuring the threshold at which passwords should be blocked (the existing behavior corresponds to threshold=1)

@robbah
Copy link

robbah commented May 21, 2019

I would like to use this feature as well. How can i use the treshold for symfony 3.4?

@stof
Copy link
Contributor Author

stof commented May 22, 2019

this feature is not implemented in this bundle. So it cannot be used. This issue is a feature request.

@sstok sstok added the Feature label May 24, 2019
@stof
Copy link
Contributor Author

stof commented Oct 9, 2019

This feature is supported by the NotCompromisedPassword constraint available in Symfony 4.2+.

And given there is this core constraint available, I doubt the constraint in this repo will be improved further.

@stof stof closed this as completed Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants